GoogleCodeArchive / piccolo2d

Automatically exported from code.google.com/p/piccolo2d
0 stars 0 forks source link

PLayer should do nothing when removing a camera that isn't attached #94

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create PCamera instance
2. Create a PLayer instance
3. call removeCamera on the PLayer with the PCamera as an argument

What is the expected output? What do you see instead?
It should do nothing and fail silently.

The Java standard collection libraries behave in this way too. Plus, could
complain about it, but it shouldn't throw an IndexOutOfBoundsException.

Original issue reported on code.google.com by allain.lalonde on 14 Jul 2009 at 5:32

GoogleCodeExporter commented 9 years ago

Original comment by allain.lalonde on 14 Jul 2009 at 5:38

GoogleCodeExporter commented 9 years ago
Since there's no answer I'll assume that's agreement or apathy. So, I'll give 
it a 
little longer and make the change.

Original comment by allain.lalonde on 16 Jul 2009 at 5:48

GoogleCodeExporter commented 9 years ago
Fixed in r485; relative trivial change. Instead of mapping the layer to an 
index, it 
uses the layer itself when calling remove.  Then conditionally fires property 
changes 
if a change was made.

Original comment by allain.lalonde on 17 Jul 2009 at 2:06

GoogleCodeExporter commented 9 years ago

Original comment by allain.lalonde on 17 Jul 2009 at 2:07

GoogleCodeExporter commented 9 years ago

Original comment by heue...@gmail.com on 28 Jul 2009 at 1:33