Hotspot custom handler not considering patterns in launch.xml file

[GoogleCodeExporter]

While building a custom launch.xml file, I specified "<error" and 
"<hotspot" regex patterns. They seems not handled properly by 
XmlHandlerDelegate class, code goes like this:

def HandleHotSpot(self, mainw, outbuffer, line, fname):
    ...
    ...
    if self._hotspot is not None:
        ifile, line = _FindFileLine(outbuffer, line, fname,
                                    VBScriptHandler.RE_VBS_ERROR)

If hotspot pattern (self._hotspot) *is* defined, it should be used instrad 
of VBScriptHandler.RE_VBS_ERROR pattern, isn't it ? Replacing it by 
"self._hotspot" seems to fix the problem.

I'm not sure if I have the correct "big picture" in mind though :)

Thanks
Seb

Original issue reported on code.google.com by sebastie...@gmail.com on 1 Feb 2010 at 3:07

[GoogleCodeExporter]

Ah thanks, that would be an embarrassing copy and paste error.

Checked in an (yet untested) fix to svn. Should be self._hotspot instead of the 
VBS
value.

Thanks,

Cody

Original comment by CodyPrec...@gmail.com on 1 Feb 2010 at 3:37

• Changed state: Fixed