GoogleCodeArchives / svnplot

Automatically exported from code.google.com/p/svnplot
0 stars 0 forks source link

-l option for non-root URLs not working on new SVNPlot (0.5.9) version #17

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
From the Wiki:

"-l : Update the changed line count data also. By default line count data is 
NOT updated.
You can run this step multiple times. The new revisions added in the repository 
will get added to 
database
NOTE : for version 0.5.5 -l option works only if svnrepo_url is 'repository 
root'. It doesn't work if 
the URL is inside the repository. This a bug. It will be fixed in the next 
version."

I checked out the most recent version and tested this. I found it doesn't work 
on the newest 
0.5.9 version of SVNPlot. Where should I start to try and fix this?

Thanks.

-oscar

Original issue reported on code.google.com by oscar.castaneda on 27 Aug 2009 at 12:09

GoogleCodeExporter commented 9 years ago
Please check the latest version of svnlogiter.py. I think I finally tracked all 
possible reasons for this bug and fixed them. Please check and confirm. I will 
prepare a new release after your confirmation.

Original comment by nitinbh...@gmail.com on 30 Aug 2009 at 3:21

GoogleCodeExporter commented 9 years ago
I checked out a new svnplot (revision 223) and ran 'sudo python setup.py 
install' on both Mac OS X (10.5.1) 
and Ubuntu (2.6), but could not get it to work. On Mac OS X I get a "bus error" 
as shown in the image file 
attached. On Ubuntu I get the error in the log file attached.

What version of pysvn are you using? I will continue testing and send you an 
update on anything new I find.

Thanks.
-oscar

Original comment by oscar.castaneda on 31 Aug 2009 at 7:04

Attachments:

GoogleCodeExporter commented 9 years ago
For a older version of PySVN (e.g. PySVN version 1.6.2), calls to
'root_url_from_path' crashed. I had a 'work around' for it. I commented it 
assuming
it may not be required any more. 

Anyway comment line 342 in svnlogiter.py (i.e. call to 'root_url_from_path'). 
And
uncomment line 346 (i.e. call to 'self.getRootUrlSlow()')

Hopefully it will fix the crash and you will be able test the fix for line 
count problem.

Original comment by nitinbh...@gmail.com on 31 Aug 2009 at 2:06

GoogleCodeExporter commented 9 years ago
The line numbers changed, on revision 223 it's lines 355 and 359, respectively 
the following:

#self.svnrooturl = self.svnclient.root_url_from_path(self.svnrepourl)

self.getRootUrlSlow()

So I commented and uncommented those respectively as you advised. Now I get 
other errors shown in the 
attached log file.

Thanks.
-oscar

Original comment by oscar.castaneda on 31 Aug 2009 at 7:08

Attachments:

GoogleCodeExporter commented 9 years ago
looks a different issue. I will check today night.

Original comment by nitinbh...@gmail.com on 1 Sep 2009 at 4:15

GoogleCodeExporter commented 9 years ago
I checked out revision 225 and tested. I'm getting similar errors for both root 
and non-root URLs. Furthermore, 
the errors occur on both 'http' and 'https' URLs. I tested on Mac OS X (10.5.7) 
and Ubuntu (2.6). Attached you will 
find the corresponding log files. 

I will continue testing and will let you know if I find anything new.

Thanks.
-oscar

Original comment by oscar.castaneda on 1 Sep 2009 at 6:55

Attachments:

GoogleCodeExporter commented 9 years ago
For some reason svnlog2sqlite it is not detecting directories, trying to do a 
diff the directory. I tried running it on rietveld repository, somehow it 
worked. I will try with the apache repositories today. 

Original comment by nitinbh...@gmail.com on 2 Sep 2009 at 12:28

GoogleCodeExporter commented 9 years ago
I have test the latest version ( Revision 228) with url 
http://svn.eu.apache.org/repos/asf/httpd/mod_mbox/. Now it seems to be working 
with this url. I am continuing my testing on other repositories. Please check 
the current version. Sorry for troubling you so many times.

Original comment by nitinbh...@gmail.com on 2 Sep 2009 at 3:46

GoogleCodeExporter commented 9 years ago
It indeed works! I tested with the url you mentioned previously. I used the 
'-l' switch and it ran fine. Then I 
processed with svnplot.py and was able to see a LoC. I also tested with 
https://svn.eu.apache.org/repos/asf/incubator/cassandra and found it to work as 
well! Now i'll integrate with 
svnlogiter.py in the ocastaneda_gsoc09 branch (which allows collection of svn 
logs for specific time periods). I 
will also continue testing with other URLs and will report back here in case I 
find anything unusual.

Thanks for all your help!

Best,
-oscar

Original comment by oscar.castaneda on 2 Sep 2009 at 7:17

GoogleCodeExporter commented 9 years ago

Original comment by nitinbh...@gmail.com on 3 Sep 2009 at 3:06

GoogleCodeExporter commented 9 years ago
I've been away for a while, but wanted to confirm that this fix works for me.  

Thanks,
Matt

Original comment by matt%kla...@gtempaccount.com on 8 Sep 2009 at 7:18