search

GoogleContainerTools / container-debug-support

Language-runtime support files for in-container debugging
Apache License 2.0
93 stars 25 forks source link

feat(go): support Go 1.20 and Delve 1.20.1 #124

Closed brumhard closed 1 year ago

brumhard commented 1 year ago

Debugging containers built with go1.20 does not work with the latest release since delve is not up to date (see https://github.com/go-delve/delve/blob/master/CHANGELOG.md#1201-2022-12-12, support for go1.20 was added in delve 1.20).

This PR basically mirrors the structure defined in https://github.com/GoogleContainerTools/container-debug-support/commit/a8b41f5c21645275e6885dbefe82924b97a56e1b, hope that works.

brumhard commented 1 year ago

@briandealwis could you take a look :) Our debugging environment is pretty much blocked by this.

aaron-prindle commented 1 year ago

Thanks for the PR here @brumhard ! Seems there is a failing test on this PR currently, also there is a similar PR submitte here - https://github.com/GoogleContainerTools/container-debug-support/pull/126. Going to meet w/ the current skaffold debug maintainer @briandealwis and get more info so I can support this repo better and get this PR in. Will update you when I know more, thanks

aaron-prindle commented 1 year ago

Thanks for the PR here, I've gone and merged the other PR that added this support (#126). Going to close this PR