search

GoogleContainerTools / container-debug-support

Language-runtime support files for in-container debugging
Apache License 2.0
93 stars 25 forks source link

feat: golang / dlv 1.23 support #139

Open zarenner opened 1 month ago

zarenner commented 1 month ago

Delve 1.20 no longer works properly with newer Golang versions (e.g. err variables show as nil even when non-nil). Updating to 1.23.0 which appears to fix the issue.

I included some changes I needed to run the tests locally (e.g. disable pushing integration test images), not sure if needed for CI but I don't think should hurt. I also removed the tests for now unsupported Golang versions.

google-cla[bot] commented 1 month ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

zarenner commented 1 month ago

CLA signed

zarenner commented 1 month ago

Note previous (unmerged) PR https://github.com/GoogleContainerTools/container-debug-support/pull/138 for 1.22