search

GoogleContainerTools / container-debug-support

Language-runtime support files for in-container debugging
Apache License 2.0
93 stars 25 forks source link

Build and test on arm64 #82

Open briandealwis opened 3 years ago

briandealwis commented 3 years ago

We discovered that the arm64 images were based on amd64 base images (#78) that went undiscovered as

  1. We weren't running tests on arm64 — I wasn't aware that Travis supported arm64.
  2. I was performing manual tests using Docker Desktop for M1 and Minikube, and Docker Desktop installs binfmt_exec extensions to allow non-native images.

We're also hitting frequent rate limiting issues with Docker Hub on Travis. Since Github Actions supports builds in amd64 and arm64, so we should run tests there.

aaron-prindle commented 3 years ago

I made this related issue on skaffold repo - https://github.com/GoogleContainerTools/skaffold/issues/5989

Would this github action be on container-debug-support repo or skaffold repo? Thanks

briandealwis commented 3 years ago

I think this repo for now. We’ve talked about merging this repo into skaffold but a bit hesitant due to how to build images and test.

aaron-prindle commented 3 years ago

Re: Since Github Actions supports builds in amd64 and arm64, so we should run tests there.

I think that Github only supports arm64 via self-hosted runners: https://docs.github.com/en/actions/hosting-your-own-runners/using-self-hosted-runners-in-a-workflow https://github.com/actions/virtual-environments/issues/2552#issuecomment-771478000 https://github.com/actions/virtual-environments/issues/2187

Just to clarify, was this your understanding when comparing Travis vs Github actions here?