GoogleContainerTools / container-debug-support

Language-runtime support files for in-container debugging
Apache License 2.0
93 stars 25 forks source link

chore: update delve to 1.7.2 #88

Closed shaxbee closed 2 years ago

shaxbee commented 3 years ago

Add Go 1.17 test. Support Go 1.13 and 1.14 in tests by specyfing --check-go-version=false option.

Skaffold is now built using Go 1.15.

shaxbee commented 3 years ago

@briandealwis care to review? Lack of delve update it's causing lots of pain with Skaffold adoption - Go 1.17 has been out since August.

briandealwis commented 2 years ago

Sorry for the delay: Skaffold needs to set the --check-go-version=false to avoid breaking existing installations that are using Go 1.13 or Go 1.14.

google-cla[bot] commented 2 years ago

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

briandealwis commented 2 years ago

I've added a commit that

briandealwis commented 2 years ago

@googlebot I consent