Closed shaxbee closed 2 years ago
@briandealwis care to review? Lack of delve update it's causing lots of pain with Skaffold adoption - Go 1.17 has been out since August.
Sorry for the delay: Skaffold needs to set the --check-go-version=false
to avoid breaking existing installations that are using Go 1.13 or Go 1.14.
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.
We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent.
in this pull request.
Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla
label to yes
(if enabled on your project).
ℹ️ Googlers: Go here for more info.
I've added a commit that
--check-go-version
in go113 and go114 as skaffold debug
does not do this--check-go-version
to false@googlebot I consent
Add Go 1.17 test. Support Go 1.13 and 1.14 in tests by specyfing
--check-go-version=false
option.Skaffold is now built using Go 1.15.