GoogleContainerTools / distroless

🥑 Language focused docker images, minus the operating system.
Apache License 2.0
18.17k stars 1.11k forks source link

fix: remove pkg_tar workaround from temurin archive #1582

Open thesayyn opened 2 months ago

thesayyn commented 2 months ago

Removes the workaround for executable files in temurin_archive and replaces it with tar from bazel-lib. This PR introduces a new system dependency awk for the build. @loosebazooka is awk installed on cloudbuild runners?

Some diff is expected, because tar rule preserves both numeric and non-numeric owner for files and defaults to file mode on disk.

Also https://github.com/aspect-build/bazel-lib/pull/829 landed, i will remove genrule once there's a new release of bazel-lib.

github-actions[bot] commented 2 months ago

🌳 🔄 Image Check

This pull request has modified the following images:

//java:java21_root_arm64_debian12
//java:java21_root_ppc64le_debian12
//java:java21_nonroot_amd64_debian12
//java:java21_nonroot_arm64_debian12
//java:java21_root_amd64_debian12
//java:java21_debug_nonroot_ppc64le_debian12
//java:java21_debug_root_arm64_debian12
//java:java21_debug_nonroot_amd64_debian12
//java:java21_debug_root_ppc64le_debian12
//java:java21_debug_root_amd64_debian12
//java:java21_debug_nonroot_arm64_debian12
//java:java21_nonroot_ppc64le_debian12

You can check the details in the report here

loosebazooka commented 2 months ago

@thesayyn seeing directories with odd permissions (from the diff report)

File     usr/lib/jvm/temurin21_jre_arm64/conf/security/policy/                                                Mode 0x1ed                                                    Mode 0x0

Current 0755 New 0000

which looks incorrect to me. Is that just what's provided by the temurin archive? But I can't seem to figure out what's going on here.

loosebazooka commented 2 months ago

found some other issues here. Duplicate entries of the same file (ex:/usr) wont load up in docker.