search

GoogleContainerTools / jib-extensions

Apache License 2.0
117 stars 35 forks source link

Add fast-jar support for Quarkus Maven plugin #141

Closed zanmagerl closed 1 year ago

zanmagerl commented 1 year ago

This resolves the issue #92. Similar was done in #129 for Gradle plugin, but this is for the Maven plugin. Most of the code is therefore more or less the same.

Sidenote: when will be a new release of the aforementioned Gradle Quarkus plugin?

elefeint commented 1 year ago

The lack of release was my oversight, sorry. It's released now.

mpeddada1 commented 1 year ago

Thank you for your contribution! This is looking good. I've added some minor comments. Please let me know if you have any questions.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.1% 94.1% Coverage
0.2% 0.2% Duplication

zanmagerl commented 1 year ago

Thank you for your contribution! This is looking good. I've added some minor comments. Please let me know if you have any questions.

Thanks for reviewing and for suggestions for improvements! Fixes are present in another commit.