GoogleContainerTools / jib-extensions

Apache License 2.0
117 stars 35 forks source link

Replace deprecated command with environment file #155

Closed jongwooo closed 1 year ago

jongwooo commented 1 year ago

Thank you for your interest in contributing! For general guidelines, please refer to the contributing guide.

Before submitting a pull request, please make sure to:

Fixes #154 🛠️

Update .github/workflows/sonar.yml to use environment file instead of deprecated set-output command. For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow file that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

run: echo "::set-output name=date::$(date +'%Y-%m-%d' --utc)"

TO-BE

run: echo "date=$(date +'%Y-%m-%d' --utc)" >> $GITHUB_OUTPUT
sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

lqiu96 commented 1 year ago

Thanks!