GoogleContainerTools / jib

🏗 Build container images for your Java applications.
Apache License 2.0
13.5k stars 1.42k forks source link

fix: allow pushing images with different arch/os to docker daemon #4268

Closed mpeddada1 closed 1 week ago

mpeddada1 commented 1 month ago

Fixes #4265

mpeddada1 commented 4 weeks ago

Notes on kokoro-ubuntu timeout:

Unable to reproduce locally with ./gradlew clean build :jib-core:integrationTest.

kokoro-macos:

chanseokoh commented 3 weeks ago

@mpeddada1 just so you know, it sounds like #4267 is another issue introduced by #4249 in 3.4.3.

mpeddada1 commented 3 weeks ago

@mpeddada1 just so you know, it sounds like #4267 is another issue introduced by #4249 in 3.4.3.

Thank you @chanseokoh! Given that it is not reproducible in 3.4.2, the change in logging behavior may connected to some of the modifications made in https://github.com/GoogleContainerTools/jib/pull/4249. Will take a deeper look to understand what causes the difference in behavior for windows (perhaps in a separate dedicated PR).

mpeddada1 commented 3 weeks ago

Regarding the integration test behavior on the CI:

Observations:

mpeddada1 commented 2 weeks ago

[Update on CI] Splitting the test methods up into separate test classes no longer causes the builds to be stuck. Ready for another round of review.

geoand commented 1 week ago

Thanks for the fix folks!

As we are seeing someone reporting something similar in Quarkus, would it be possible to know an approximate timeline for a release of jib-core that will contain the fix? Thanks!

calebAtIspot commented 1 week ago

should https://github.com/GoogleContainerTools/jib/blob/master/docs/faq.md#how-do-i-specify-a-platform-in-the-manifest-list-or-oci-index-of-a-base-image be updated? It still says "Does not support pushing to a Docker daemon"