Azurite Blob Store not supported due to regex?

GoogleContainerTools / kaniko

Build Container Images In Kubernetes

Apache License 2.0

14.86k stars 1.44k forks source link

Azurite Blob Store not supported due to regex? #1309

Open maxhillaert opened 4 years ago

maxhillaert commented 4 years ago

I assumed kaniko would work with an on-premise blob store using Azurite Blob Storage, but it looks like it's tied to the Cloud Azure Blob Storage domain name

Would it be difficult to support this? It should be the same API.

tejal29 commented 4 years ago

yes, @maxhillaert we do support Azure blob with these naming conventions here It would be easy to update this regular expression and add tests for the newly add expression.

dgzlopes commented 4 years ago

I peeked a little on this issue.

I'm not sure how easy is to update the list of regular expressions, Azurite Blob Storage is a self-hosted/on-premise project.

Any host-suffix can be valid, right? Maybe this check can be disabled with some kind of flag?