Closed LeTraceurSnork closed 2 weeks ago
If you stick to semantic versioning, then:
PATCH version when you make backwards compatible bug fixes
This change really breaks backwards compatibility.
@chuangw6 please check this as you were release-master
The closest thing I could find to a versioning policy in this repo is
In most cases, you will need to bump the VERSION_MINOR number. In case you are doing a patch release for a hot fix, bump the VERSION_BUILD number.
in https://github.com/GoogleContainerTools/kaniko/blob/main/RELEASE.md.
So I think your assumption that this project follows semver and the release "MUST BE major" is probably unfounded.
It would be good if maintainers could clarify the versioning policy (and ideally commit to following semver to avoid unexpected breakage in people's build pipelines).
Sorry for the issues you had here @LeTraceurSnork. I believe it was incorrect to release this as v1.9.1
when it likely should have been v1.10.0
. The most recent releases (v1.10.0
, v1.11.0
) are following the correct semver usage bumping the minor version number (VERSION_MINOR
in the Makefile). The breaking changes you encountered were likely related to an unintentioal regression which we can work to fix. I will re-title this issue to relate to the specific issue you encountered
Actual behavior Running kaniko with option
--cache-copy-layers=true
causes build error and failed pipeline on GitLab CI when Dockerfile contains more than oneCOPY
directiveExpected behavior The same, but since that behavior is clearly backwards incomatible, release MUST BE major due to semver
To Reproduce Steps to reproduce the behavior:
Dockerfile
with more than oneCOPY
layerkaniko
with--cache-copy-layers=true
to build this imageAdditional Information
WORKDIR /usr/src/wordpress
Copy Everything we need
COPY . ./
Composer installation
COPY --from=composer /usr/bin/composer /usr/bin/composer
RUN composer install