GoogleContainerTools / kaniko

Build Container Images In Kubernetes
Apache License 2.0
14.25k stars 1.4k forks source link

"Fixes #2752" #3132

Closed Samarth08 closed 1 month ago

Samarth08 commented 2 months ago

Making --no-push and remote caching work with each other/

Fixes #2752

Description • Setting NoPush to opts.NoPush instead of hardcoding it.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

Reviewer Notes

Release Notes Fixes#2752 Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- kaniko adds a new flag `--registry-repo` to override registry
google-cla[bot] commented 2 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

mschneider82 commented 2 months ago

the test failed because of go fmt was not executed on your modified file.

Samarth08 commented 2 months ago

@JeromeJu