GoogleContainerTools / kaniko

Build Container Images In Kubernetes
Apache License 2.0
14.25k stars 1.4k forks source link

Fix: add retries to fs cleanup #3136

Open ezloj opened 2 months ago

ezloj commented 2 months ago

Fixes 1697

Description

This attempts to mitigate some of the sources for issues described in https://github.com/GoogleContainerTools/kaniko/issues/1697

The potential problems that this might address is when something is writing to the filesystem during it's deletion but is otherwise safe to be removed anyway

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

Reviewer Notes

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- kaniko adds a new flag `--retry-cleanup` to run filesystem cleanup retries for multistage builds and for builds that explicitly ask for cleanup with the `--cleanup` flag
google-cla[bot] commented 2 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

ezloj commented 3 weeks ago

Bumping... Is there a chance someone can look into this and merge? Looks like all the checks have passed and there already is one approval here :)

StefanSchrass commented 3 weeks ago

I would put a ribbon on this MR if I could, because this issue is a severe pain in the neck for my usecase.