GoogleContainerTools / kaniko

Build Container Images In Kubernetes
Apache License 2.0
14.23k stars 1.4k forks source link

fix: Properly disable logging timestamps when --log-timestamp=false (… #3214

Closed hrivera-ntap closed 1 week ago

hrivera-ntap commented 1 week ago

…#3213)

Fixes #3213

Description

Pass in DisableTimestamp into the logrus TextFormatter to ensure that timestamps get enabled or disabled correctly.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

Reviewer Notes

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Properly disable logging timestamps when `--log-timestamp=false` is used with either `--log-format=text` or `--log-format=color`
google-cla[bot] commented 1 week ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.