GoogleContainerTools / kaniko

Build Container Images In Kubernetes
Apache License 2.0
14.9k stars 1.44k forks source link

Multi-stage builds execute CI in the last stage context instead of reverting to the job image. #3325

Open ivanchubb opened 1 month ago

ivanchubb commented 1 month ago

Actual behavior

When executing a multi-stage build (particularly evident when the last stage is FROM scratch) after the executor finishes, the rest of the script in the CI job maintains the context of the built image instead of reverting back to the context of the image defined at the job level. This causes unexpected errors when trying to do any parsing or log aggregation after running the exeuctor.

Expected behavior

Expected behavior is after the executor completes, the shell would return to the context of the image specified in the CI job.

To Reproduce Steps to reproduce the behavior:

  1. Create a multi-stage Dockerfile where the first stage builds the binary and the second stage is FROM scratch
  2. Create a ci job with image: kaniko:1.23.2 where the executor is ran.
  3. In the same job, after the executor runs, add to the script command that should exist in kaniko:1.23.2, but not in the final stage of the Dockerfile (for example: sed). The command will fail with "sed not found".

Additional Information

erikdao commented 1 month ago

Upvote for this report since I'm facing a very similar issue.

mzihlmann commented 1 month ago

could you be looking for the --cleanup flag?

https://github.com/GoogleContainerTools/kaniko#flag---cleanup

ivanchubb commented 1 month ago

could you be looking for the --cleanup flag?

https://github.com/GoogleContainerTools/kaniko#flag---cleanup

Just tried that and it doesn't help

feifei325 commented 1 day ago

I have a similar problem. I observed that when using kaniko to build multiple levels, Example command: /kaniko/executor --context dir:///{codePath} ... When the Dockerfile contains the following command COPY --from={baseImage} /{targetPath} After the COPY command is executed, {codePath} will be cleared. I am not sure why

After executing COPY --from=, execute ADD . .