GoogleContainerTools / kaniko

Build Container Images In Kubernetes
Apache License 2.0
14.95k stars 1.45k forks source link

Log that an image has been pushed successfully #812

Open priyawadhwa opened 5 years ago

priyawadhwa commented 5 years ago

So that the user knows kaniko is done

current output is

INFO[0000] Resolved base name busybox to busybox        
INFO[0000] Resolved base name busybox to busybox        
INFO[0000] Downloading base image busybox               
INFO[0001] Error while retrieving image from cache: getting file info: stat /workspace/cache/sha256:dd97a3fe6d721c5cf03abac0f50e2848dc583f7c4e41bf39102ceb42edfd1808: no such file or directory 
INFO[0001] Downloading base image busybox               
INFO[0002] Built cross stage deps: map[]                
INFO[0002] Downloading base image busybox               
INFO[0003] Error while retrieving image from cache: getting file info: stat /workspace/cache/sha256:dd97a3fe6d721c5cf03abac0f50e2848dc583f7c4e41bf39102ceb42edfd1808: no such file or directory 
INFO[0003] Downloading base image busybox               
INFO[0003] Unpacking rootfs as cmd Run echo hey requires it. 
INFO[0004] Taking snapshot of full filesystem...        
INFO[0005] Run echo hey                                 
INFO[0005] cmd: /bin/sh                                 
INFO[0005] args: [-c echo hey]                          
hey
INFO[0005] Taking snapshot of full filesystem...        
INFO[0006] No files were changed, appending empty layer to config. No layer added to image. 

we used to rely on go-containerregistry logs to do this for us, but maybe they've changed.

codevbus commented 5 years ago

@priyawadhwa - I'd like to take this.

priyawadhwa commented 5 years ago

@codevbus awesome, I will assign you. Please cc me on any PRs you open.

donmccasland commented 5 years ago

reviewing your PR now.

codevbus commented 5 years ago

@donmccasland - FWIW that PR fixes a different issue with the docs/shell script... still working in this issue, although I appear to be blocked by: https://github.com/GoogleContainerTools/kaniko/issues/720

tomikmar commented 4 years ago

I would also include full image name in such log.

Currently logs are confusing. It seems that Kaniko stopped before pushing image to repository.