search

GoogleContainerTools / kpt-config-sync

Config Sync - used to sync Git, OCI and Helm charts to your clusters.
Apache License 2.0
229 stars 40 forks source link

refactor: use SourceType type in RSync spec #1289

Closed sdowell closed 1 week ago

sdowell commented 1 week ago

This changes the type of the sourceType field from string to the defined type in the RSync spec. This reduces the number of type conversions required and makes the code more self documenting.

The intent is to apply a similar refactor to SourceFormat with a subsequent PR.

google-oss-prow[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nan-yu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleContainerTools/kpt-config-sync/blob/main/OWNERS)~~ [nan-yu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment