search

GoogleContainerTools / kpt-config-sync

Config Sync - used to sync Git, OCI and Helm charts to your clusters.
Apache License 2.0
229 stars 40 forks source link

Update Go, kubernetes, controller-runtime, etc. #1302

Open karlkfi opened 2 days ago

karlkfi commented 2 days ago

Depends on https://github.com/GoogleContainerTools/kpt-config-sync/pull/1308 to fix go-licenses

google-oss-prow[bot] commented 2 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from karlkfi. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleContainerTools/kpt-config-sync/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
karlkfi commented 1 day ago

I don't really understand why, but go-licenses is now erroring with Non go modules projects are no longer supported. errors on a lot of go stdlib packages. AFAIK, that requirement was added in go-licenses v1.1.0. So I don't know what changed in this PR to trigger a new error from the same version of go-licenses.

google-oss-prow[bot] commented 1 day ago

@karlkfi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kpt-config-sync-presubmit 5216bd2f85e12743e2126e81ef8be02572e11db8 link true /test kpt-config-sync-presubmit
kpt-config-sync-presubmit-e2e-multi-repo-test-group1 5216bd2f85e12743e2126e81ef8be02572e11db8 link true /test kpt-config-sync-presubmit-e2e-multi-repo-test-group1
kpt-config-sync-presubmit-e2e-multi-repo-test-group3 5216bd2f85e12743e2126e81ef8be02572e11db8 link true /test kpt-config-sync-presubmit-e2e-multi-repo-test-group3
kpt-config-sync-presubmit-e2e-multi-repo-test-group2 5216bd2f85e12743e2126e81ef8be02572e11db8 link true /test kpt-config-sync-presubmit-e2e-multi-repo-test-group2
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).