search

GoogleContainerTools / kpt-config-sync

Config Sync - used to sync Git, OCI and Helm charts to your clusters.
Apache License 2.0
244 stars 43 forks source link

Feature: pause hydration when image verification fails #1487

Open tiffanny29631 opened 2 weeks ago

google-oss-prow[bot] commented 2 weeks ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

google-oss-prow[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from tiffanny29631. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleContainerTools/kpt-config-sync/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tiffanny29631 commented 1 week ago

Is it possible to add unit tests for the blocking feature?

Working on an e2e test now. The check of readyToRenderCommit happens in the controller Run function so is not easy to emulate, we could check for the warning message in hydration-controller log when commit is not as expected, and pass when an image with dry config syncs correctly - meaning hydration is resumed.

tiffanny29631 commented 4 days ago

@nan-yu e2e test in place, ready for another look.