[WIP] chore: move reconciler to reconciler package

GoogleContainerTools / kpt-config-sync

Config Sync - used to sync Git, OCI and Helm charts to your clusters.

Apache License 2.0

244 stars 43 forks source link

[WIP] chore: move reconciler to reconciler package #1493

Closed karlkfi closed 1 week ago

karlkfi commented 1 week ago

Move reconciler to reconciler package
Move SyncStatusClient to a new syncclient package, to avoid import cycles betwen parse and reconciler.
Make some structs, fields, methods, funcs public to allow use between packages.

This is a test to see what needs fixing before we can cleanly perform this refactor.

TODO:

Replace or cleanup cacheForCommit
Refactor parse.Options so it's not being used for multiple struct types (reconciler, parsers, sync status clients, etc).
Move Files methods into the parser and remove Files (same as FileSource but with methods)
Add public constructors for parsers and sync status clients.
Make SourceState and its field public. Or figure out how to use it cleanly without 3 packages sharing access.

google-oss-prow[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from karlkfi. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleContainerTools/kpt-config-sync/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

google-oss-prow[bot] commented 1 week ago

@karlkfi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
kpt-config-sync-presubmit	0ba3a68f63db9753534d52504a5b9b0c12104fa1	link	true	`/test kpt-config-sync-presubmit`

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).