GoogleContainerTools / kpt-config-sync

Config Sync - used to sync Git, OCI and Helm charts to your clusters.
Apache License 2.0
243 stars 43 forks source link

chore: split parse & update methods #1495

Closed karlkfi closed 4 days ago

karlkfi commented 1 week ago

I want to do more to clean up cacheForCommit, to add updateResult, and split sourceResult into fetchResult and renderResult, but this seems like enough for one PR.

google-oss-prow[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nan-yu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleContainerTools/kpt-config-sync/blob/main/OWNERS)~~ [nan-yu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nan-yu commented 4 days ago

/lgtm