Check if CacheWriter#writeLayer's parameters are correct. - Githubissues

GoogleContainerTools / minikube-build-tools-for-java

Minikube lifecycle management tools for Gradle and Maven.

Apache License 2.0

57 stars 27 forks source link

Check if CacheWriter#writeLayer's parameters are correct. #102

Closed coollog closed 6 years ago

coollog commented 6 years ago

In https://github.com/GoogleCloudPlatform/minikube-build-tools-for-java/pull/101, new CacheWriter#writeLayer signatures take a layer reference and its BLOB separately. The written BLOB should have its digest checked against the supplied reference to make sure that the layer reference and BLOB match.

Possible reasons for why they don't match include:

the user of the method passed incorrect parameters
the BLOB was corrupted
the BLOB was not pulled correctly from the registry