Closed coollog closed 7 years ago
It might be useful to auto-populate the "tag" parameter with something like $ORGANIZATION/$PROJECT_NAME:$VERISON
Okay, how about having a field like:
imageTagConfig
- nested with properties: organizationName
, projectName
, version
(Configures the task with -t <organizationName>/<projectName>:<version>
)
@loosebazooka
Also, @loosebazooka , it seems that the Dockerfile must be in the build context, so a default context of build/libs
with a default Dockerfile of src/main/docker/Dockerfile
would not work.
I think you can just have those be base properties on the task, with defaults pulled from the gradle config, like project.version and project.name?
What if the user wanted to not use the auto-populated task? Should we include another property called useAutoGeneratedTag
that defaults to true?
I'm not sure what the override order is, but if the user uses -t in "flags", that should override whatever we've configured from imageTagConfig
(or whatever that config ends up being)
The user can actually specify multiple -t tags, and it will tag the same image with each tag that is provided, so there is no override.
Closed pending design for new way of building with the Minikube Docker environment.
Currently,
minikubeDockerBuild
(#7) takes acontext
andflags
.We want it to be more helpful by providing some default
docker build
parameters as part of the task configuration:~~1.
dockerfile
- configures the task with-f <value>
src/main/docker/Dockerfile
prepareMinikubeDockerBuild
that prepares the context to use forminikubeDockerBuild
. Takes parameters:context
: the task syncs this tobuild/docker
build/libs
dockerfile
: the task syncs this tobuild/docker/Dockerfile
src/main/docker/Dockerfile
minikubeDockerBuild
usebuild/docker
for its context and depends on the successful execution of theprepareMinikubeDockerBuild
task.tag
- configures the task with-t <value>
${project.group}/${project.name}:${project.version}
Please comment with more ideas about what configuration to provide. The above list will be updated with more ideas.