search

GoogleContainerTools / minikube-build-tools-for-java

Minikube lifecycle management tools for Gradle and Maven.
Apache License 2.0
57 stars 27 forks source link

set logging level to info #145

Closed gintautassulskus closed 5 years ago

gintautassulskus commented 6 years ago

https://github.com/GoogleContainerTools/minikube-build-tools-for-java/issues/144

loosebazooka commented 6 years ago

@coollog did we have this at lifecycle before because it was a separate task? info does seem like the right level, but I can't remember why it was lifecycle before.

coollog commented 6 years ago

I believe lifecycle was just an arbitrary choice and info is more appropriate. getDockerEnv is just a method on the extension and not a separate task.

coollog commented 6 years ago

Hi @gintautassulskus , looks like a test failed. Running ./gradlew build should be able to reproduce this:

com.google.cloud.tools.minikube.util.CommandExecutorTest > testRunCommandWithLogging_success FAILED
    org.mockito.exceptions.verification.VerificationInOrderFailure: 
    Verification in order failure
    Wanted but not invoked:
    loggerMock.lifecycle("some output line 1");
    -> at com.google.cloud.tools.minikube.util.CommandExecutorTest.testRunCommandWithLogging_success(CommandExecutorTest.java:127)
    Wanted anywhere AFTER following interaction:
    loggerMock.debug(
        "Running command : someCommand someOption"
    );
    -> at com.google.cloud.tools.minikube.util.CommandExecutor.run(CommandExecutor.java:89)
        at com.google.cloud.tools.minikube.util.CommandExecutorTest.testRunCommandWithLogging_success(CommandExecutorTest.java:127)
gintautassulskus commented 6 years ago

Apologies. Negligence due to rushing things.