search

GoogleContainerTools / minikube-build-tools-for-java

Minikube lifecycle management tools for Gradle and Maven.
Apache License 2.0
57 stars 27 forks source link

Profile support for dockerEnv() extension #146

Closed gintautassulskus closed 6 years ago

gintautassulskus commented 6 years ago

https://github.com/GoogleContainerTools/minikube-build-tools-for-java/issues/141

Added profile support for dockerEnv() extension

dockerEnv(), dockerEnv("") - refer to default minikube profile dockerEnv(profile) - refer to custom minikube profile

gintautassulskus commented 6 years ago

Thanks for the useful remarks! Addressed.

gintautassulskus commented 6 years ago

@loosebazooka, I could not find any documentation on this. Here's the issue for the documentation request: https://github.com/kubernetes/minikube/issues/2371

Could just link to that issue.

loosebazooka commented 6 years ago

@gintautassulskus I'm a little curious about what the exact behavior is, I'll try talking to the minikube team and see if I can get a followup on that issue.

gintautassulskus commented 6 years ago

If you have a particular question, let me know. I may be able to answer it as well. Our development workflow relies on profile feature but unfortunately not all the tools support it. So far bash it all! solution worked out best.