GoogleContainerTools / minikube-build-tools-for-java

Minikube lifecycle management tools for Gradle and Maven.
Apache License 2.0
57 stars 27 forks source link

Invert dependency between AbstractHashingBlob and its subclasses. #64

Closed coollog closed 6 years ago

coollog commented 6 years ago

AbstractHashingBlob.java "In general, I would like to lean towards the composition model for code sharing. Perhaps HashingStringBlob and HashWriterBlob could share this code through a third object that is passed to them?" - @loosebazooka

loosebazooka commented 6 years ago

I ran into this too with InputStreamBlob and FileStreamBlob, you can compose with templates if you chose to do so.