Add other CacheWriter#writeLayer signatures

GoogleContainerTools / minikube-build-tools-for-java

Minikube lifecycle management tools for Gradle and Maven.

Apache License 2.0

57 stars 27 forks source link

Add other CacheWriter#writeLayer signatures #98

Closed coollog closed 6 years ago

coollog commented 6 years ago

writeLayer(ReferenceLayer/DigestOnlyLayer/ReferenceNoDiffIdLayer, Blob) should write base image layers pulled from a registry to the cache, calculating the diff ID when necessary.

loosebazooka commented 6 years ago

Can you elaborate on this bug a little more?

coollog commented 6 years ago

Currently, the CacheWriter only writes application layers to the cache, but we need to write base image layers to the cache as well. In a later PR, I actually change most of the changes in #101 , so I can just close that PR and have the changes come in from the later PR since it will probably make more sense on how it will be used there.