search

GoogleContainerTools / skaffold

Easy and Repeatable Kubernetes Development
https://skaffold.dev/
Apache License 2.0
15.03k stars 1.62k forks source link

Additional helm flags per release #2959

Open reductor opened 5 years ago

reductor commented 5 years ago

Currently additional helm flags can only be specified that apply to all releases, it would be ideal to be able to specify per-release helm flags this would provide better flexibility for workarounds such as issue #1665 where --repo could be added as an install flag

priyawadhwa commented 5 years ago

Hey @ReDucTor thanks for opening this feature request. It seems reasonable to have per-release flags. The easiest way to implement this would probably be to add HelmDeployFlags to the HelmRelease type, and that pass that in to helm here for that specific release.

I don't love this solution because we already use HelmDeployFlags to specify flags to pass in to all releases, and it feels weird to use it again per-release, but I can't think of a cleaner way to do it. Would be happy to hear any suggestions.

If you, or anyone else, would be interested in submitting a PR for this issue, please comment on this thread. I can assign you to the issue & review any PRs.