search

GoogleContainerTools / skaffold

Easy and Repeatable Kubernetes Development
https://skaffold.dev/
Apache License 2.0
15.02k stars 1.62k forks source link

Should Event API follow CNCF's Cloud Events #4259

Open balopat opened 4 years ago

balopat commented 4 years ago

We should consider standardizing our Event API to follow CNCF's https://cloudevents.io/ standard.

Benefits: better alignment with the space, standardized format which aligns better with best practices Cons: IDEs will need to restructure their clients

Thoughts?

nkubala commented 4 years ago

seems a bit heavyweight, but I wouldn't mind standardizing around a spec that we don't have to maintain. it would make building on top of our API much more robust too. I don't consider restructuring the IDE clients too much of a blocker here since it would be a one time change. would like to see a POC for this

aaron-prindle commented 3 years ago

@baleshk expressed interest in this issue, waiting on them to comment on then I will assign it

baleshk commented 3 years ago

@aaron-prindle pls let me take a stab on this one.

baleshk commented 3 years ago

First draft of cloudevent implementation can be found at: https://github.com/baleshk/skaffold/tree/v3events . @nkubala this can serve as a POC you asked for.

baleshk commented 3 years ago

Hi All,

Please find the pull request (Draft) for this feature at https://github.com/baleshk/skaffold/pull/2/files . CC: @aaron-prindle @nkubala

Thanks