Logs are missed after code change

GoogleContainerTools / skaffold

Easy and Repeatable Kubernetes Development

https://skaffold.dev/

Apache License 2.0

14.97k stars 1.62k forks source link

Logs are missed after code change #4785

Open etanshaul opened 4 years ago

etanshaul commented 4 years ago

copied from https://github.com/GoogleCloudPlatform/cloud-code-intellij-internal/issues/2584#

Start a skaffold k8s session with an app that contains a readiness probe (the specific setup with a spring-boot app using Jib)
Make a code edit

expected: logs continue streaming actual: some of the application logs are not printed until the readiness probe passes (the theory); e.g. the spring boot start up logs are not printed.

See these comments from the copied issue.

nkubala commented 4 years ago

hmm, i wonder what the right UX is here. definitely a motivating use case for having multiple output "streams" (one for application logs, one for status updates from the readiness probe, etc.)

briandealwis commented 3 years ago

So the problem is that on subsequent dev iterations, we mute the logs prior to redeploy and then unmute the logs after the deployment is complete (which includes waiting for status checks). Muting and unmuting doesn't try to catch up with what was logged in the interim.

It could be better to Stop() and Start() the logger instead, similar to what we do in the first iteration. Except our logger.Start()/.Stop() aren't meant to be called repeatedly (yet).

tejal29 commented 3 years ago

quarterly bug scrub update: /cc @nkubala to look at this as part of new logger redesign in #5813 and #5936