Documentation: Font Awesome search icon placeholder broken

GoogleContainerTools / skaffold

Easy and Repeatable Kubernetes Development

https://skaffold.dev/

Apache License 2.0

15.08k stars 1.63k forks source link

Documentation: Font Awesome search icon placeholder broken #4903

Closed thomas-riccardi closed 4 years ago

thomas-riccardi commented 4 years ago

The font awesome 5 free web font is somehow not used in the search dom element, so the placeholder isn't substituted.

(changing the font-weight to 900 does make it work, but it's not necessary on upstream docsy demo site https://example.docsy.dev/ ; I stopped the investigation there).

gsquared94 commented 4 years ago

I couldn't figure much out other than if you delete this line:

<script src="https://kit.fontawesome.com/077204b73e.js" crossorigin="anonymous"></script>

then it shows up correctly: but far fa-gem goes missing:

Maybe we should explicitly add the font-awesome js and css files instead of using a kit? (Not a frontend dev 😅)

IsaacPD commented 4 years ago

I managed to make the magnifying glass appear within my browser by changing the font used for that element from "font awesome 5 free" to "FontAwesome"

https://github.com/GoogleContainerTools/skaffold/blob/29d522ff1895036793245cb439246b56e4e64f05/docs/layouts/partials/navbar.html#L36

The search-input.html partial is part of docsy so it must be due to one of the style sheets I guess.