Helm wait=true waits for indefinitely and timedout

s-u-b-h-a-k-a-r commented 3 years ago

Expected behavior

Skaffold build indefinitely waits when the flag wait=true. This was happening for remote repositories.

Actual behavior

Starting deploy... Helm release ambassador not installed. Installing... manifest_sorter.go:192: info: skipping unknown hook: "crd-install" manifest_sorter.go:192: info: skipping unknown hook: "crd-install" manifest_sorter.go:192: info: skipping unknown hook: "crd-install" manifest_sorter.go:192: info: skipping unknown hook: "crd-install" manifest_sorter.go:192: info: skipping unknown hook: "crd-install" manifest_sorter.go:192: info: skipping unknown hook: "crd-install" manifest_sorter.go:192: info: skipping unknown hook: "crd-install" manifest_sorter.go:192: info: skipping unknown hook: "crd-install" manifest_sorter.go:192: info: skipping unknown hook: "crd-install" manifest_sorter.go:192: info: skipping unknown hook: "crd-install" manifest_sorter.go:192: info: skipping unknown hook: "crd-install" manifest_sorter.go:192: info: skipping unknown hook: "crd-install" manifest_sorter.go:192: info: skipping unknown hook: "crd-install" manifest_sorter.go:192: info: skipping unknown hook: "crd-install" manifest_sorter.go:192: info: skipping unknown hook: "crd-install" manifest_sorter.go:192: info: skipping unknown hook: "crd-install" manifest_sorter.go:192: info: skipping unknown hook: "crd-install" manifest_sorter.go:192: info: skipping unknown hook: "crd-install" Error: timed out waiting for the condition Cleaning up... manifest-1

Information

Skaffold version: v1.16.0
Helm version: v3.4.0
Operating system: Ubuntu
Contents of skaffold.yaml:

apiVersion: skaffold/v2beta8
kind: Config
metadata:
  name: polygot-microservices
build:
  artifacts:
    - image: subhakarkotta/polygot-microservices-python
      context: applications/python-service
      docker:
         dockerfile: Dockerfile
    - image: subhakarkotta/polygot-microservices-spring
      context: applications/spring-service
      jib: {}
    - image: subhakarkotta/polygot-microservices-go
      context: applications/go-service
      docker:
         dockerfile: Dockerfile
deploy:
  helm:
    releases:
      - name: ambassador 
        wait: true
        chartPath: datawire/ambassador
        namespace: ambassador
        createNamespace: true
        remote: true
      - name: consul 
        wait: true
        chartPath: hashicorp/consul
        namespace: consul
        createNamespace: true
        remote: true
        valuesFiles: [ helm-charts/consul/values.yaml ]
      - name: go-service 
        wait: true
        chartPath: helm-charts/go-service
        namespace: default
        artifactOverrides:
          image.repository: subhakarkotta/polygot-microservices-go
        valuesFiles: [ helm-charts/go-service/values.yaml ]
      - name: python-service 
        wait: true
        chartPath: helm-charts/python-service
        namespace: default
        artifactOverrides:
          image.repository: subhakarkotta/polygot-microservices-python
        valuesFiles: [ helm-charts/python-service/values.yaml ]
      - name: spring-service 
        wait: true
        chartPath: helm-charts/spring-service
        namespace: default
        artifactOverrides:
          image.repository: subhakarkotta/polygot-microservices-spring
        valuesFiles: [ helm-charts/spring-service/values.yaml ]
      - name: consul-resolver 
        chartPath: helm-charts/consul-resolver
        namespace: default
        valuesFiles: [ helm-charts/consul-resolver/values.yaml ]

Steps to reproduce the behavior

skaffold build

tejal29 commented 3 years ago

@SubhakarKotta are you trying skaffold deploy instead of skaffold build

Looks like, skaffold is timing out installing the remote chart.

Helm release ambassador not installed. Installing...

Also, looks there are some issue with helm chart https://github.com/helm/charts/issues/21690#Helm-fails-to-create-CRDs manifest_sorter.go:192: info: skipping unknown hook: "crd-install"

s-u-b-h-a-k-a-r commented 3 years ago

@SubhakarKotta are you trying skaffold deploy instead of skaffold build

Looks like, skaffold is timing out installing the remote chart.
Helm release ambassador not installed. Installing...
Also, looks there are some issue with helm chart helm/charts#21690 (comment) manifest_sorter.go:192: info: skipping unknown hook: "crd-install"

This is an expected info and this was happening with other remote chart as well. But when I install the remote chart manually without using skaffold I doesn't see any stuck and it installs smoothly.

GoogleContainerTools / skaffold