GoogleContainerTools / skaffold

Easy and Repeatable Kubernetes Development
https://skaffold.dev/
Apache License 2.0
14.93k stars 1.62k forks source link

Support configuring status check independently between modules #5746

Open maggieneterval opened 3 years ago

maggieneterval commented 3 years ago

Expected behavior

For a skaffold.yaml containing multiple pipelines, it is valid to configure the Deploy.StatusCheck value for each independently.

Actual behavior

For a skaffold.yaml containing multiple pipelines, it is invalid to set the Deploy.StatusCheck value to true for one pipeline and false for another. (See discussion on https://github.com/GoogleContainerTools/skaffold/pull/5706 for details.)

Information

apiVersion: skaffold/v2beta14
kind: Config
build:
  artifacts:
  - image: skaffold-example
deploy:
  kubectl:
    manifests:
      - k8s-*
  statusCheck: true 
---
apiVersion: skaffold/v2beta14
kind: Config
build:
  artifacts:
  - image: skaffold-example
deploy:
  kubectl:
    manifests:
      - k8s-*
  statusCheck: false

Steps to reproduce the behavior

  1. Run skaffold dev using a skaffold.yaml similar to the example above.
MarlonGamez commented 3 years ago

@maggieneterval thanks for opening up this issue! We really appreciate all of the recent contributions :)

maggieneterval commented 3 years ago

@MarlonGamez no problem, huge thanks to you and team for helping me ramp up and make my first contributions!

nkubala commented 3 years ago

just leaving a comment to make triage party happy! and @maggieneterval let us know if you're actively taking up this work :)