search

GoogleContainerTools / skaffold

Easy and Repeatable Kubernetes Development
https://skaffold.dev/
Apache License 2.0
15.08k stars 1.63k forks source link

[FR] CompositeTagger TagPolicy #622

Closed jonjohnsonjr closed 5 years ago

jonjohnsonjr commented 6 years ago

I'm interested in using multiple tag policies together as a poor man's https://grafeas.io.

Any plans for something like this? Open to a PR?

r2d4 commented 6 years ago

+1 for me. Not sure if the model should be

  1. (no config change) just specify multiple taggers and each one will be applied. Can't specify multiple of the same type (mostly make sense, except envTaggers can be different)
  2. (config changE) a list of taggers with types that get applied, can have multiple of the same type
radityasurya commented 6 years ago

+1

nkubala commented 6 years ago

@jonjohnsonjr are you still at all interested in this? PRs happily accepted :)

FWIW I think @r2d4's second option (config change to add a list of taggers to be used) is the better solution here.

jonjohnsonjr commented 6 years ago

I probably won't implement it myself, but I still think it's a good idea 😄

btardell commented 5 years ago

I'm interested in being able to apply multiple tags too for tracking deployments. Putting everything in a single tag for traceability is not pretty. Individual tags will make this cleaner.

balopat commented 5 years ago

Also, as @btardell mentioned in https://github.com/GoogleContainerTools/skaffold/issues/2534, supporting this as flags would be interesting too.

tejal29 commented 5 years ago

This is dupe of #1269