search

GoogleContainerTools / skaffold

Easy and Repeatable Kubernetes Development
https://skaffold.dev/
Apache License 2.0
14.93k stars 1.62k forks source link

(Feature Request) Support ValueFile from Google Cloud Stroage #9172

Open asubramanianrl opened 10 months ago

asubramanianrl commented 10 months ago

Expected behavior

Skaffold should read the ValueFile from Google Storage Bucket as well(with Application Default Credential)

    patches:
      - op: add
        path: /deploy/helm/releases/0/valuesFiles
        value:
          - env-values/dev-values.yaml
          - external-configuration/env-values/dev-values.yaml
          - gs://XXXX/ops.yaml

Actual behavior

We hold the infrastructure-related information in the Storage Bucket and it must be available publicly to pass it to the Helm. Due to security reasons, we want to block the public usage of this bucket. At the moment, we will have a workaround to download this file using the prehook and pass it with the local path.

    patches:
      - op: add
        path: /deploy/helm/releases/0/valuesFiles
        value:
          - env-values/dev-values.yaml
          - global/env-values/dev-values.yaml
          - https://storage.googleapis.com/XXXX/ops.yaml
asubramanianrl commented 10 months ago

I would like to take the opportunity to contribute.

What is the best way to copy the files from GCS? I see that Skaffold is using the gsutil cmd to pull the manifests. Can I try the same or use the GCS SDK ?