GoogleContainerTools / skaffold

Easy and Repeatable Kubernetes Development
https://skaffold.dev/
Apache License 2.0
15k stars 1.62k forks source link

skaffold run always forces redeploy with helm renderer #9222

Open joreetz-otto opened 10 months ago

joreetz-otto commented 10 months ago

Expected behavior

'skaffold run' should only force a new revision of a deployment if there are any changes in the code. This is currently not the case. But rendering skaffold and applying it manually via kubectl does not force a new revision. skaffold render | kubectl --context gke_abc --namespace abc apply -f -

Actual behavior

Information

apiVersion: skaffold/v4beta6
kind: Config
metadata:
  name: abc
build:
  artifacts:
    - image: abc/abc
      context: ../abc
      docker:
        dockerfile: Containerfile
        pullParent: true
  local:
    push: true
    useBuildkit: true
    concurrency: 0
  tagPolicy:
    sha256: {}
deploy:
  kubectl:
    defaultNamespace: abc
  tolerateFailuresUntilDeadline: true
manifests:
  helm:
    releases:
      - name: abc
        chartPath: helm-charts/abc
        namespace: abc
        setValues:
          nothing_interesting: true
        setValueTemplates:
          image.digest: "{{ .IMAGE_DIGEST_abc_abc }}"
          image.repository: "{{ .IMAGE_REPO_abc_abc }}"
          image.tag: "{{ .IMAGE_TAG_abc_abc }}"
        createNamespace: true
        wait: true
  rawYaml:
    - manifests/namespace_abc.yaml
profiles:
  - name: dev
    deploy:
      kubeContext: gke_abc_dev
  - name: prd
    deploy:
      kubeContext: gke_abc_prd
  - name: tst
    deploy:
      kubeContext: gke_abc_tst
joreetz-otto commented 10 months ago

Minimal version to reproduce: https://github.com/joreetz-otto/skaffold_9222