search

GoogleContainerTools / skaffold

Easy and Repeatable Kubernetes Development
https://skaffold.dev/
Apache License 2.0
15.05k stars 1.62k forks source link

fix: emit CloudRunServiceReady event even if default url is disabled #9523

Closed bskaplan closed 1 month ago

bskaplan commented 2 months ago

Fixes: #9522

Description Only emit CloudRunServiceReady event if the status is success, and emit it even if no URL is present which could be the case if default-url-disabled is set to true

User facing changes (remove if N/A) Before: A creation or update of a service with annotation run.googleapis.com/default-url-disabled: true would not emit a CloudRunServiceReady event. If an update of an existing service failed, CloudRunServiceReady event would be emitted.

After: A CloudRunServiceReady event is only populated if the Ready condition is successful, and is populated even if the default URL is disabled.

idsulik commented 2 months ago

@bskaplan , thank you for the contribution, I'm not the maintainer, but I left a couple of comments

renzodavid9 commented 2 months ago

Hey @bskaplan, thanks for helping us with this one 😄. Just a small nit, but it looks good. Just waiting for the integration test to finish.