GoogleForCreators / web-stories-wp

Web Stories for WordPress
https://wp.stories.google
Apache License 2.0
766 stars 178 forks source link

Story not loading in player after exiting the lightbox #13241

Closed LuckynaSan closed 1 year ago

LuckynaSan commented 1 year ago

Bug Description

A user reported the story player is not loading or displaying as a black screen after viewing it and closing out of the lightbox.

Expected Behaviour

Story loads in player after closing out of lightbox or viewing it again.

Steps to Reproduce

  1. Go to site https://newsmaker.com.ar/
  2. Click on story
  3. Skip through each story
  4. Close out of lightbox
  5. View first story again
  6. Notice black screen

Screenshots

https://user-images.githubusercontent.com/66372350/234609877-2c60c1e9-c721-4ede-8390-70119ddb3593.mov

Additional Context

Related support topic: https://wordpress.org/support/topic/more-than-2-stories-black-screen-second-time/

udaykanths commented 1 year ago

Hi team,

Is there any option to revert to the earlier version? My site ( https://sareeing.com/web-stories/ ) is currently on "Version 1.33.0" , and facing the issue repeatedly.

I have my other site which is working absolutely perfect. It is running on “Version 1.32.0” ( https://telugu.sareeing.com/web-stories/ )

It seems the issue is from quite a long time & it creating problem on my site ‘s performance.

Please give some solution.

udaykanths commented 1 year ago

Dear team, please let us know how many months it requires to fix the issue. Probably we will uninstall or disable web stories till then. The reason for the dissatisfaction is, this issue hugely impacted on our google "discover performance". Even though users can see our web stories, they get an error the moment they open the story. Hence it looks like the website itself has a problem. Hope the team of internet's game changing application... "Google Web stories" will understand us & do the needful. thank you.

swissspidy commented 1 year ago

I doubt that this is related to performance on Google Discover, but you might be pleased to hear that we're currently actively looking into this issue.

udaykanths commented 1 year ago

Hello @swissspidy , It is the reason for the performance on Google Discover. Especially for latest web story published, unfortunately it won't work after some time, The link is opening a blank page. And again we need to go with 'Quick Edit' & save the web story, so that it will work for a while. Again after some time, the issue repeats. Again we need to go with 'Quick Edit'. This is the problem from past 2 months. P.S.:

  1. This is for a complete new visitor, not related to skipping.
  2. In most scenarios, The latest web story is not working. Refer the link: https://www.loom.com/share/1e579f405004404d892be57717fc8798 Please do the needful on high priority. Regards, Udaykanth S
swissspidy commented 1 year ago

What you are describing is an entirely issue from what is being tracked here. Please open a new support topic on WordPress.org so that we can assist you with that.

AnuragVasanwala commented 1 year ago

Previous Finding

@swissspidy Initially, after a lot of debugging I came to conclusion that amp-story-player had bug while setting up iframe src: https://github.com/ampproject/amphtml/blob/4ce3cd79520dbeaf5ed5364cbff58d3d71dee40e/src/amp-story-player/amp-story-player-impl.js#L1268-L1270

Later on, after so many testing - I found AMP didn't have any bug related. I also crated a sample HTML page to demonstrate story with Lightbox. Working HTML page is attached here:

📄 Expand: HTML WebStory with Lightbox ``` Lightbox Example

Web Stories

Q&A with ZOE Newman
24 Hours in New York City
The Next King of the Sea
Spark a Passion for Reading
```

Recent Finding

@swissspidy It seems like this LightBox issue started after fixing #12999 issue.

Commenting out following browser history lines solves the issue: https://github.com/GoogleForCreators/web-stories-wp/blob/a3c73c2942cf1966c5e0073f6478d7b89fed8134/packages/stories-lightbox/src/web-stories-lightbox.js#L61 https://github.com/GoogleForCreators/web-stories-wp/blob/a3c73c2942cf1966c5e0073f6478d7b89fed8134/packages/stories-lightbox/src/web-stories-lightbox.js#L130

Seems like pushing storyObject.href to history is having some conflict with AMP 🤔

swissspidy commented 1 year ago

Ah, interesting, we're onto something! 👀