Closed Swanand01 closed 1 week ago
Those Warning: You are importing createRoot from "react-dom" which is not supported. You should instead import it from "react-dom/client".
warnings are unfortunately a known issue in core. We can ignore those messages in the bootstrap.js
file.
@Swanand01 I don't think it's a timeout issue. The selector seems to have changed, .editor-post-publish-button[aria-disabled="true"]
isn't correct anymore in 6.6. Or maybe it's because the text changed from Update
to Save
I'm going to try to revert the changes I made, to at least make the E2E tests pass on a 6.4 and 6.5. The issue is I am unable to run the tests locally due to some mariadb problem, so I'm unable to run the tests before committing. Maybe @AnuragVasanwala could help with the problem in 6.6-RC1?
I'm going to try to revert the changes I made, to at least make the E2E tests pass on a 6.4 and 6.5. The issue is I am unable to run the tests locally due to some mariadb problem, so I'm unable to run the tests before committing. Maybe @AnuragVasanwala could help with the problem in 6.6-RC1?
Nevermind, only had to add a conditional to check if the button's textContent
matches "Update" or "Save". No other changes necessary.
Size Change: 0 B
Total Size: 2.76 MB
Plugin builds for c1e6795e26d8a7e663a577b1ca9f069a97e54632 are ready :bellhop_bell:!
Summary
This PR updates tests to run against WP 6.6-RC1.
User-facing changes
None.
Testing Instructions
None.
Reviews
Does this PR have a security-related impact?
No.
Does this PR change what data or activity we track or use?
No.
Does this PR have a legal-related impact?
No.
Checklist
Type: XYZ
label to the PRFixes #13702