GoogleWebComponents / google-chart

Google Charts API web components
https://www.webcomponents.org/element/@google-web-components/google-chart/elements/google-chart
Apache License 2.0
358 stars 130 forks source link

Removed a trailing coma #183

Closed borisbsv closed 7 years ago

borisbsv commented 7 years ago

A trailing coma on line 8 was forcing making the json unparesable by the likes of bower. I know it's a terribly small change, but it's necessary for bower compatibility

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


borisbsv commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!

wesalvaro commented 7 years ago

Hey @TemplarRei, thanks for catching this! I'm afraid that this update is still very much a work in progress; I haven't even tested Bower, yet. I'm currently making so many heavy changes locally and doing force pushes after rebasing that this branch just isn't ready yet for PRs... It's definitely not guaranteed to be stable, even though that's what I'm going for. After finishing out the feature with the dashboard bindings (as well as writing and updating all the tests), I'll get it design and code reviewed so that we can start using and ironing the bugs out of it ASAP. I'm glad you're testing it out, please let me know what you think!

borisbsv commented 7 years ago

Thanks @wesalvaro! I'll test more and add things if/when I can. And I know it's the smalles change, so I only mentioned it because it breaks bower.

wesalvaro commented 7 years ago

No problem! I pushed the latest version with your comma. It should be feature complete, now. I just need to get tests added and reviewed before merging it back into the master.