Declare _chart and _dataView in properties

GoogleWebComponents / google-chart

Google Charts API web components

Apache License 2.0

358 stars 130 forks source link

Closed rslawik closed 5 years ago

rslawik commented 5 years ago

JS compiler aggresively renames them. They are used in an observer, so they should not be renamed.

wesalvaro commented 5 years ago

Make sure you're getting code review for changes, please.

rslawik commented 5 years ago

Ack, it looked like a trivial and uncontroversial change and it was blocking a team, so I made an emergency exception.

wesalvaro commented 5 years ago

Np!