search

GoogleWebComponents / google-chart

Google Charts API web components
https://www.webcomponents.org/element/@google-web-components/google-chart/elements/google-chart
Apache License 2.0
357 stars 130 forks source link

Timeline chart selection infinite loop #256

Closed rslawik closed 5 years ago

rslawik commented 5 years ago

After change to ChartWrapper, setting selection on timeline chart causes an infinite loop.

It turns out that the timeline chart does not follow the protocol for the select event: https://developers.google.com/chart/interactive/docs/events#the-select-event. It emits select when setSelection is called.

This affects internal users: b/141123421

rslawik commented 5 years ago

Live example of broken chart: https://jsbin.com/bitadixumo/edit?html,output Error: Maximum call stack size exceeded

rslawik commented 5 years ago

Live example of fixed chart: https://jsbin.com/powuyuloco/1/edit?html,output