GoogleWebComponents / google-map

Google Maps web components
https://elements.polymer-project.org/elements/google-map
Other
437 stars 256 forks source link

attribute native hidden and title in Polymer 2 #427

Open kimagure44 opened 6 years ago

kimagure44 commented 6 years ago
      Solved the failure in polymer 2 with the hidden attribute. 
       When you use the Google Maps component in Polymer 2 the hidden attribute is not working as in Polymer 1, 
       it only works the first time. 
       It seems that with the native attributes of html 'hidden', 'title', etc ... in polymer 2 in this 
       component they do not react to the change.I have reviewed the 'attributeChanged' method and it 
       appears as deprecated and according to the official documentation they recommend using 
       the 'attributeChangedCallback' method, but it behaves the same with the native attributes.
       I imagine that since they are native attributes they have a behavior that in polymer 1 if it worked 
       but in polymer 2 it does not do in binding.
       Solution: The first solution was to create a property that would replace the behavior of the hidden 
       or the title, but the final solution is much simpler. You have to declare the native 
       attributes 'hidden' or 'title' as properties of the component, in this way Native attributes 
       work correctly
googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
kimagure44 commented 6 years ago

I signed it!