GoogleWebComponents / google-map

Google Maps web components
https://elements.polymer-project.org/elements/google-map
Other
437 stars 256 forks source link

Get neglected tests to pass in Chrome #436

Open cratonica opened 5 years ago

cratonica commented 5 years ago

I was unable to get the tests to all pass in FireFox due to https://github.com/Polymer/polymer/issues/4146, but this at-least gets them passing in Chrome.

This will give me some confidence that I didn't break anything after I run it through Modulizer.

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
cratonica commented 5 years ago

I'm a Googler, so I don't need to sign the CLA.

googlebot commented 5 years ago

CLAs look good, thanks!