Closed nodirt closed 8 years ago
Nice patch, fits well with the existing code. My only issue is the parameter name: "Prompt". Without reading the docs, I'd assume propmt would modify prompt text. Instead, it is an obscure open_id option. Could we change it to openidPrompt? That name is scary enough it'd drive people who do not know what they are doing away.
Renamed the property.
I am not experienced with pull requests. Do you want me to squash these commits into one or you are ok merging three commits?
I understand, github merging pushes into pull requests feels a bit too magical. Your request looks good. @ebidel this looks like a useful feature, and code lgtm. Can we merge it?
@addyosmani 's the maintainer. He should have a look.
Addressed comments
Friendly ping
@nodirt do not worry. addy is busy, he'll get to it and most probably merge it in.
Add prompt property to and
elements. Its docs:
Updated demo and used it to test.
Fixes #128