Fix firing google-signed-out at initialization

GoogleWebComponents / google-signin

Google Sign-in web component

https://elements.polymer-project.org/elements/google-signin

Other

279 stars 89 forks source link

Fix firing google-signed-out at initialization #140

Closed masonlouchart closed 7 years ago

masonlouchart commented 8 years ago

This commit avoids to fire the google-signed-out event when the element initializes its property "signedIn". When the element is created, its property "signedIn" changes from "undefined" to "false". At this time, it shouldn't send event. It's the reason why I added the condition on the previous value.

fixes #139

esd100 commented 7 years ago

Why hasn't this been merged? It has been almost an entire year? C'mon people @addyosmani @Zoramite

atotic commented 7 years ago

Looks reasonable.