search

GoogleWebComponents / google-signin

Google Sign-in web component
https://elements.polymer-project.org/elements/google-signin
Other
279 stars 89 forks source link

fix #146 #147

Closed jmsgomes closed 8 years ago

jmsgomes commented 8 years ago

Fix #146

atotic commented 8 years ago

LGTM

Zoramite commented 8 years ago

@jmsgomes Could you rebase the changes against the master?

jmsgomes commented 8 years ago

Rebased :-)

I had to fix one more thing because of a new ERROR - assignment to property properties of GoogleSigninElement.prototype caused by the "hanging" @param declarations in the JSDoc. Unfortunately, I messed up the git "history" by committing an earlier alternate workaround (move @event blocks to the end of the Polymer declaration) in the rebase, before coming up with the final approach I chose (which got its own separate commit). Let me know if I need to do something different.

Note: I gleaned from the discussion in https://github.com/Polymer/hydrolysis/issues/103 that ideally we'd use @typedef but it's not supported yet AFAICT. So I went with using a "separator" comment block...