search

GoogleWebComponents / google-signin

Google Sign-in web component
https://elements.polymer-project.org/elements/google-signin
Other
279 stars 89 forks source link

Add initialized property to detect when auth library has initialized #153

Closed solidsystem closed 7 years ago

solidsystem commented 7 years ago

To be able to easily display something like a dialog when user is not signed in, we need to know when the signedIn property is set based on first reponse from auth library rather than the default false value.

Adding a property such as this change does makes this possible.

I believe this solves issue #137 and #121 as well as my own need for such a feature.

Zoramite commented 7 years ago

This looks good to me.

Zoramite commented 7 years ago

@ebidel This change looks good to me for allowing the user to know if the library has initialized before reading the logged in status without backwards incompatibility. I don't have write access to the repo anymore so if you can check this out it would be good.